[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Goo Nitpicks (condition hierarchy)



Christopher Armstrong <carmstro@twistedmatrix.com> writes:

> On Thu, 2002-08-01 at 19:19, Christopher Armstrong wrote:
> > I know I have more issues, but I can't remember them atm. I'll be
> > sending more email. :-)
> 
> Ok, another one: I really really really love the fact that goo has a
> sane type/class hierarchy, but I think the condition hierarchy sucks.
> Having basic `simple-condition' `serious-condition' etc conditions is a
> cool idea that I hadn't thought of, but I think it also _really_ needs
> more fine-grained conditions, associated with particular operations
> (again, like Python has ;-)).

i agree.

> goo/user 2<= (elt (vec) 2)
> ERROR: RANGE ERROR #[] 2
> 
> IMO, this should throw a "range-error" condition, not just an "error"
> condition.
> 
> goo/user 3<= ueoa
> ERROR: Unbound binding: ueoa
> 
> "binding-error".
> 
> etc.
> 
> Oh, and while I'm staring at the examples: man, that all-caps stuff is
> ugly (as well as the formatting of the message). How about "range-error:
> <vec> index out of range"? :-)

i like all caps, but i realize i'm probably in the minority, so yes,
i'll change it.

> And, on the subject of contributing: are you going to be opening up your
> CVS repository, at least for reading-privelages, any time soon?  It'll
> make it a lot easier to write and send patches.

as you know, we just did, and is available through the wiki.

jonathan